Remove excessive warning re graph variant #3043
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
I'm going to land this, but I think this error message still provides value. Could we:
- Re-instate this, but in a more centralized place (like, when Engine itself is enabled?). It seems like other aspects of the Platform could benefit from this.
- Only have it shown once per startup/invocation.
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…r#3043) * Remove excessive warning re graph variant * Add CHANGELOG.md for apollographql/apollo-server#3043. Apollo-Orig-Commit-AS: apollographql/apollo-server@e8e8b60
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove excessive logging about missing graph variant.